This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Display an error message if room not found #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else if (this.props.canJoin) { | ||
| var name = this.props.room ? this.props.room.name : ""; | ||
| else if (this.props.error) { | ||
| var name = this.props.roomAlias || "This room"; |
There was a problem hiding this comment.
roomAlias needs adding to propTypes
Merged
| @@ -117,6 +117,10 @@ module.exports = React.createClass({ | |||
| guestsCanJoin: false, | |||
| canPeek: false, | |||
|
|
|||
| // If we failed to load information about the room, | |||
| // store the error here. | |||
|
lgtm otherwise |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#1012
Also remove the canJoin prop from RoomPreviewBar which was only ever set to true.